Repository navigation
aws: retries, timeouts and SDK errors, taken over from the #603 client - #612
Merged
Merged
Conversation
The clients used the botocore defaults. Use the standard retry mode with 5 attempts and a connect timeout of 10 seconds, the way the client in #603 did, and add a test that fails when a client is created without it. Co-authored-by: Eric Krichbaum <11653069+ekrichbaum@users.noreply.github.com>
A lost connection, a timeout, missing credentials or an unknown profile raised a bare botocore exception out of discover(), discover_organization() or the session setup, although the module promises AWSDiscoveryError for every failure that is not an authorization denial. Wrap them the way the client in #603 did and add tests for all three. Co-authored-by: Eric Krichbaum <11653069+ekrichbaum@users.noreply.github.com>
semx
changed the title
|
I rebased to your version and it generated a few thousand log issues in a dry run against my production instances. The version removed custom_fields from NBCluster/NBVirtualDisk and stopped advertising |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two things the client in #603 by @ekrichbaum did and ours did not, found by reading the two
client.pyfiles side by side. Both commits carry him as co-author.The clients were created with the botocore defaults. They now use the standard retry mode with 5 attempts and a connect timeout of 10 seconds (the read timeout stays at 60).
A lost connection, a timeout, missing credentials or an unknown profile raised a bare botocore exception out of
discover(),discover_organization()or the session setup, although the module says every failure that is not an authorization denial is anAWSDiscoveryError. These are wrapped now.The new tests fail on
development(five of them: the config values, the 8 places that create a client withoutconfig=, and the three error paths) and pass with this change, together with the 191 existing AWS tests (196 passed).