Repository navigation
tests: cover unsetting the primary MAC of an interface - #611
Merged
Merged
Conversation
remove_interface_association() has to unset the MAC address as primary MAC of its interface, NetBox refuses to unassign it otherwise. The test fails on development and passes with #609.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Covers the change in #609: removing the interface association of a MAC address has to unset it as primary MAC of the interface (
unset_items), NetBox refuses to unassign it otherwise.On
developmentthe test fails (unset_itemsstays empty because the unset goes to the device, which has no such field), with #609 merged it passes.