Repository navigation
docker: let requirements-aws.txt into the build context - #610
Merged
Merged
Conversation
The Dockerfile copies requirements-aws.txt since the AWS source landed, but .dockerignore is a whitelist and did not list it, so the image build on development has been failing with "/requirements-aws.txt": not found. Also rebuild the image when that file changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Dockerfile copies
requirements-aws.txtsince the AWS source (#608) landed, but.dockerignoreis a whitelist and did not list it, so the image build ondevelopmentfails with"/requirements-aws.txt": not foundandghcr.io/bb-ricardo/netbox-sync:developmenthas not been updated since 29 October.This adds the file to
.dockerignore, and to the paths that trigger the build.Checked with
docker buildx buildon Ubuntu 24.04 (the builder CI uses): without the change the build stops with exactly that error, with it the image builds anddocker run ns -hprints the usage.