Repository navigation
Do not write add / to .deb ar file names. - #1085
Merged
Merged
Conversation
aiuto
changed the title
cgrindel
approved these changes
Oct 6, 2026
gh-worker-dd-mergequeue-cf854d Bot
pushed a commit
to DataDog/datadog-agent
that referenced
this pull request
Oct 12, 2026
…58001) ### What does this PR do? Repin the `rules_pkg` `archive_override` to upstream main at bazelbuild/rules_pkg#1084 and drop the local patch it supersedes. ### Motivation bazelbuild/rules_pkg#1084, applied as a patch since #57825, got merged but is not released yet, the latest release being 1.3.0. ### Describe how you validated your changes The dropped patch reverse-applies cleanly on the new archive. With RPM 6.0.1, the `//packages/installer/linux` and `//packages/dogstatsd` RPMs and DEBs build, and `MakeRpm` actions hit the cache, which shows they are unchanged. ### Additional Notes The new pin also brings bazelbuild/rules_pkg#1085, which drops the trailing `/` from `.deb` ar member names, as `dpkg-deb` itself does, so we're better with it. Co-authored-by: regis.desgroppes <regis.desgroppes@datadoghq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Do not write add / to .deb ar file names.
This makes it compatible with
dpkg-deband less incompatible with BSDar.ar tvon Linux should strip it and show debian-binary.dpkgtolerates it, but doesn't write it. deb(5) says member names may end in / anddpkghas accepted that since about 1.15.6.dpkg-debitself writes names with no slash, so our output is not canonical.