Add Vim style navigation to Menu, Clipboard, Emoji & Image-Picker - #8318
Open
Kylar514 wants to merge 1 commit into
Open
Add Vim style navigation to Menu, Clipboard, Emoji & Image-Picker#8318Kylar514 wants to merge 1 commit into
Kylar514 wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds Ctrl-modified Vim navigation to four Quickshell launcher surfaces while preserving existing filtering and keyboard behavior.
Changes:
- Adds Ctrl+H/J/K/L navigation to applicable panels.
- Extends shell tests with seven shortcut assertions.
- Retains existing arrow-key and search handling.
Tip
If you aren't ready for review, convert to a draft PR.
Click "Convert to draft" or run gh pr ready --undo.
Click "Ready for review" or run gh pr ready to reengage.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
shell/plugins/menu/Menu.qml |
Adds Vim-style selection, activation, and back navigation. |
shell/plugins/clipboard/Clipboard.qml |
Adds Ctrl+J/K selection navigation. |
shell/plugins/emojis/Emojis.qml |
Adds Vim-style grid navigation. |
shell/plugins/image-picker/ImagePicker.qml |
Adds Ctrl+H/L carousel navigation. |
test/shell.d/menu-test.sh |
Covers menu shortcuts. |
test/shell.d/clipboard-test.sh |
Covers clipboard shortcuts. |
test/shell.d/emojis-test.sh |
Covers emoji shortcuts. |
test/shell.d/image-picker-test.sh |
Covers image-picker shortcuts. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds control-modified vim navigation keys alongside the existing arrow-key handling in four launcher surfaces:
Ctrl+J/Kselect,Ctrl+Lactivate (like Right),Ctrl+Hback (like Left, same empty-filter guard)Ctrl+J/Kmove selectionCtrl+J/Krow jumps,Ctrl+H/Lwithin-row stepsCtrl+H/Lprevious/next imageAll new branches are gated on
Qt.ControlModifier, so unmodified letters continue to reach each panel's search filter exactly as before. Existing arrow/PageUp/Home/End behavior is untouched.Testing
test/shell.d/menu-test.sh,clipboard-test.sh,emojis-test.sh,image-picker-test.shpass, including seven new assertions covering everyadded branch
panels, filter typing unaffected, dmenu mode intact