Repository navigation
Conversation
The bulk Resend action prefilled one recipient form with every address of every selected mail and then sent each selected mail to that whole list. Resending mails that went to different people therefore delivered each of them to all the other recipients as well, which leaks personal content between recipients. The bulk action now sends every selected mail again to its own to, cc and bcc, without a shared form. Changing the recipients stays possible on the single Resend action.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The bulk Resend action on the mails table builds one form for all selected mails: its To, CC and BCC fields are prefilled with the union of the addresses of every selected mail. On submit, each selected mail is resent to that whole list.
So selecting two mails, one sent to Ann and one to Bob, and confirming the prefilled form sends Ann's mail to Ann and Bob, and Bob's mail to Ann and Bob. With transactional mail (personal links, codes, invoices) that discloses one recipient's content to everyone else in the selection. The prefilled form makes this the default path rather than a misuse.
Change
to,ccandbcc.getBulkResendForm()is removed. Changing recipients remains possible on the single-row Resend action, which only ever concerns one mail.PHPStan reports seven
method.notFounderrors inListMails.phpon5.xalready; this PR does not touch them.