Repository navigation
Drop @unchecked from SendingStorage's Sendable conformance - #701
Merged
sebsto merged 1 commit intoOct 30, 2026
Merged
Conversation
The only stored property is a Mutex, which is unconditionally Sendable, so the compiler can verify the conformance without @unchecked.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #
N/A
Description of changes
SendingStorageis declared@unchecked Sendable, but its only stored property islet storage: Mutex<Value?>.Mutexis unconditionallySendable(regardless ofValue), so the compiler can verify this conformance on its own. Dropping@uncheckedkeeps the same semantics while letting the compiler catch any future change that would make the type non-Sendable(e.g. adding a mutable stored property).Verified locally on macOS (Swift 6.4.2):
swift build -Xswiftc -strict-concurrency=completeproduces no new diagnosticsswift testpassesNew/existing dependencies impact assessment, if applicable
No new dependencies were added to this change.
Conventional Commits
refactor
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.