UB: Never expiring creds bug - #3922
Open
okruitho wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Fix non-expiring CRT credentials being incorrectly reported as expired by
CrtCredentialsProvider.CRT documents
UINT64_MAXas “no expiration”. Previously, the provider converted this sentinel into aDateTimeas though it were an ordinary timestamp, exceeding the representable range and causingIsExpired()andIsExpiredOrEmpty()to returntrue.For gcc this works fine; when using clang the casts from
uint64_ttodoubletouint64_tgive undefined behaviour, depending on compliler optimisation.Downstream impact
We encountered this in DuckDB’s AWS extension, which uses this check before copying credentials into an S3 secret. Our toolchain is clang based. The incorrect expiration status caused valid credentials to be omitted, surfacing in its MinIO integration test.
Changes
AWSCredentials’ default non-expiring value when CRT returnsUINT64_MAX.uint64_tseconds constructor for finite expiration timestamps, avoiding the floating-point conversion.falseand subsequent retrieval uses cached credentials.Check all that applies:
Check which platforms you have built SDK on to verify the correctness of this PR.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.