Skip to content

chore(format): fix formatting on FlowState enum - #2734

Merged
nborges-aws merged 1 commit into
v0.xfrom
formatting-v0
Oct 28, 2026
Merged

nborges-aws merged 1 commit into
v0.xfrom
formatting-v0

Conversation

@nborges-aws

Copy link
Copy Markdown
Contributor

Description

Fix formatting causing failure on branch CI

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation update
  • Other (please describe):

Testing

How have you tested the change?

  • I ran bun test
  • I ran the relevant end-to-end tests with bun run test:e2e, or explained why they are not applicable
  • I ran bun run typecheck
  • I ran bun run lint:check
  • I ran bun run format:check
  • I ran bun run build
  • If I modified src/assets/, I updated affected snapshots with bun test <test-file> --update-snapshots and committed them

Checklist

  • I have read the CONTRIBUTING document
  • I have added any necessary tests that prove my fix is effective or my feature works
  • I have updated the documentation accordingly
  • I have added an appropriate example to the documentation to outline the feature, or no new docs are needed
  • My changes generate no new warnings
  • Any dependent changes have been merged and published

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the
terms of your choice.

@nborges-aws
nborges-aws requested a review from a team October 28, 2026 17:19
@github-actions github-actions Bot added the size/xs PR size: XS label Oct 28, 2026
@agentcore-devx-automation agentcore-devx-automation Bot added claude-security-reviewing Claude Code /security-review in progress agentcore-harness-reviewing AgentCore Harness review in progress labels Oct 28, 2026
@agentcore-devx-automation

Copy link
Copy Markdown
Contributor

Claude Security Review: no high-confidence findings. (run)

@agentcore-devx-automation agentcore-devx-automation Bot removed the claude-security-reviewing Claude Code /security-review in progress label Oct 28, 2026

@agentcore-devx-automation agentcore-devx-automation Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AgentCore Harness Review

Verdict: Looks good

Single-file, formatting-only change to the FlowState union in src/cli/tui/screens/memory/AddMemoryFlow.tsx. The multi-line leading-| form matches what Prettier produces for this union at the repo's 120-char printWidth (the single-line type FlowState = ... ; form exceeds it), so this should resolve the format:check failure on v0.x. No behavioral or type changes — the union members are identical.

Nothing further needed from my side.

@agentcore-devx-automation agentcore-devx-automation Bot removed the agentcore-harness-reviewing AgentCore Harness review in progress label Oct 28, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Package Tarball

aws-agentcore-0.31.2.tgz

How to install

gh release download pr-2734-tarball --repo aws/agentcore-cli --pattern "*.tgz" --dir /tmp/pr-tarball
npm install -g /tmp/pr-tarball/aws-agentcore-0.31.2.tgz

@github-actions

Copy link
Copy Markdown
Contributor

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 41.75% 16052 / 38446
🔵 Statements 41% 17125 / 41767
🔵 Functions 35.72% 2764 / 7736
🔵 Branches 34.78% 10738 / 30871
Generated in workflow #4621 for commit 37c56e0 by the Vitest Coverage Report Action

@nborges-aws
nborges-aws merged commit c49cf3d into v0.x Oct 28, 2026
39 of 40 checks passed
@nborges-aws
nborges-aws deleted the formatting-v0 branch October 28, 2026 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/xs PR size: XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants