Skip to content

chore: update dependabot branch target to reflect new name - #2724

Merged
nborges-aws merged 1 commit into
v1.xfrom
dependabot-branch-naming
Oct 28, 2026
Merged

nborges-aws merged 1 commit into
v1.xfrom
dependabot-branch-naming

Conversation

@nborges-aws

Copy link
Copy Markdown
Contributor

Description

update dependabot to target the new naming convention for v0 branch

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation update
  • Other (please describe):

Testing

How have you tested the change?

  • I ran bun test
  • I ran the relevant end-to-end tests with bun run test:e2e, or explained why they are not applicable
  • I ran bun run typecheck
  • I ran bun run lint:check
  • I ran bun run format:check
  • I ran bun run build
  • If I modified src/assets/, I updated affected snapshots with bun test <test-file> --update-snapshots and committed them

Checklist

  • I have read the CONTRIBUTING document
  • I have added any necessary tests that prove my fix is effective or my feature works
  • I have updated the documentation accordingly
  • I have added an appropriate example to the documentation to outline the feature, or no new docs are needed
  • My changes generate no new warnings
  • Any dependent changes have been merged and published

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the
terms of your choice.

@github-actions github-actions Bot added the size/xs PR size: XS label Oct 28, 2026
@agentcore-devx-automation agentcore-devx-automation Bot added agentcore-harness-reviewing AgentCore Harness review in progress claude-security-reviewing Claude Code /security-review in progress labels Oct 28, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Package Tarball

aws-agentcore-1.0.1.tgz

How to install

gh release download pr-2724-tarball --repo aws/agentcore-cli --pattern "*.tgz" --dir /tmp/pr-tarball
npm install -g /tmp/pr-tarball/aws-agentcore-1.0.1.tgz

@agentcore-devx-automation

Copy link
Copy Markdown
Contributor

Claude Security Review: no high-confidence findings. (run)

@agentcore-devx-automation agentcore-devx-automation Bot removed the claude-security-reviewing Claude Code /security-review in progress label Oct 28, 2026

@agentcore-devx-automation agentcore-devx-automation Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AgentCore Harness Review

Verdict: Changes requested

The change itself is right for the end state, but as of now it points Dependabot at a branch that doesn't exist yet, so it's a merge-ordering problem.

1. v0.x does not exist yet — merging this now stalls v0 dependency updates (.github/dependabot.yml:49, :78)

The repo still has main as the v0 line (git branch -r / the branch API shows main present and no v0.x), and the comment this PR deletes (# Change target-branch to v0.x when main is renamed.) was exactly the gate for this change. Dependabot reads this file from the default branch (refactor), so the new config takes effect as soon as this merges: the two v0 entries would reference a non-existent target-branch, those update runs error out, and no v0 version-update or github-actions PRs get opened until the rename lands.

Options:

  • Keep this PR in draft and merge it immediately after main is renamed to v0.x (simplest, matches the intent of the deleted comment).
  • Do the rename first in the same change window, then merge.
  • If you want zero gap, temporarily carry both sets of v0 entries (target-branch: "main" and target-branch: "v0.x" — distinct target branches, so they're valid side by side) and drop the main ones after the rename.

2. Related heads-up: v0 branch workflow filters still key on main

Not in this diff, but it affects whether the retargeted Dependabot PRs are useful. On origin/main, build-and-test.yml, lint.yml, e2e-tests.yml, pr-tarball.yml, and pr-automation.yml all filter on branches: [main, ...] and don't include v0.x. Once the rename happens and Dependabot opens PRs against v0.x, those PRs will get no CI (only release-main-and-preview.yml already lists v0.x). Worth landing the companion filter update on the v0 branch as part of the same cutover.

Minor

Since the "change this when main is renamed" comment is being removed, consider leaving a short note (or a line in the cutover runbook) that the v0 target-branch here must track the v0 branch name — otherwise the next rename silently breaks it again. Also expect the four currently open v0 Dependabot PRs (dependabot/npm_and_yarn/main/...) to be superseded by new .../v0.x/... branches rather than updated in place; closing them after the cutover avoids duplicates.

@agentcore-devx-automation agentcore-devx-automation Bot removed the agentcore-harness-reviewing AgentCore Harness review in progress label Oct 28, 2026
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.54%. Comparing base (5febc10) to head (58cda50).

Additional details and impacted files
@@             Coverage Diff              @@
##           refactor    #2724      +/-   ##
============================================
- Coverage     96.54%   96.54%   -0.01%     
============================================
  Files           706      706              
  Lines         58529    58529              
============================================
- Hits          56508    56507       -1     
- Misses         2021     2022       +1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@nborges-aws
nborges-aws marked this pull request as ready for review October 28, 2026 15:56
@nborges-aws
nborges-aws requested a review from a team October 28, 2026 15:56
@nborges-aws
nborges-aws merged commit e2f59da into v1.x Oct 28, 2026
27 of 28 checks passed
@nborges-aws
nborges-aws deleted the dependabot-branch-naming branch October 28, 2026 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/xs PR size: XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants