Repository navigation
chore: update dependabot branch target to reflect new name - #2724
Conversation
Package TarballHow to installgh release download pr-2724-tarball --repo aws/agentcore-cli --pattern "*.tgz" --dir /tmp/pr-tarball
npm install -g /tmp/pr-tarball/aws-agentcore-1.0.1.tgz |
|
Claude Security Review: no high-confidence findings. (run) |
There was a problem hiding this comment.
AgentCore Harness Review
Verdict: Changes requested
The change itself is right for the end state, but as of now it points Dependabot at a branch that doesn't exist yet, so it's a merge-ordering problem.
1. v0.x does not exist yet — merging this now stalls v0 dependency updates (.github/dependabot.yml:49, :78)
The repo still has main as the v0 line (git branch -r / the branch API shows main present and no v0.x), and the comment this PR deletes (# Change target-branch to v0.x when main is renamed.) was exactly the gate for this change. Dependabot reads this file from the default branch (refactor), so the new config takes effect as soon as this merges: the two v0 entries would reference a non-existent target-branch, those update runs error out, and no v0 version-update or github-actions PRs get opened until the rename lands.
Options:
- Keep this PR in draft and merge it immediately after
mainis renamed tov0.x(simplest, matches the intent of the deleted comment). - Do the rename first in the same change window, then merge.
- If you want zero gap, temporarily carry both sets of v0 entries (
target-branch: "main"andtarget-branch: "v0.x"— distinct target branches, so they're valid side by side) and drop themainones after the rename.
2. Related heads-up: v0 branch workflow filters still key on main
Not in this diff, but it affects whether the retargeted Dependabot PRs are useful. On origin/main, build-and-test.yml, lint.yml, e2e-tests.yml, pr-tarball.yml, and pr-automation.yml all filter on branches: [main, ...] and don't include v0.x. Once the rename happens and Dependabot opens PRs against v0.x, those PRs will get no CI (only release-main-and-preview.yml already lists v0.x). Worth landing the companion filter update on the v0 branch as part of the same cutover.
Minor
Since the "change this when main is renamed" comment is being removed, consider leaving a short note (or a line in the cutover runbook) that the v0 target-branch here must track the v0 branch name — otherwise the next rename silently breaks it again. Also expect the four currently open v0 Dependabot PRs (dependabot/npm_and_yarn/main/...) to be superseded by new .../v0.x/... branches rather than updated in place; closing them after the cutover avoids duplicates.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## refactor #2724 +/- ##
============================================
- Coverage 96.54% 96.54% -0.01%
============================================
Files 706 706
Lines 58529 58529
============================================
- Hits 56508 56507 -1
- Misses 2021 2022 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Description
update dependabot to target the new naming convention for v0 branch
Type of Change
Testing
How have you tested the change?
bun testbun run test:e2e, or explained why they are not applicablebun run typecheckbun run lint:checkbun run format:checkbun run buildsrc/assets/, I updated affected snapshots withbun test <test-file> --update-snapshotsand committed themChecklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the
terms of your choice.