Skip to content

fix(solver): restore the reject condition broken by 1105122 #164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ocayon merged 1 commit into from
Oct 8, 2026
Merged

fix(solver): restore the reject condition broken by 1105122 #164

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/VSM/core/Solver.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1444,6 +1444,10 @@ def finite(state):
trial = evaluate(current["x"] + direction)
evaluations += 1
ratio = np.inf if finite(trial) and norm(trial) == 0 else (norm(current) / norm(trial) if finite(trial) else 0.0)
crossed_gate = finite(trial) and trial["gate"] != current["gate"]
if not finite(trial) or (
ratio < self._newton_reject_ratio
and not (crossed_gate and dt <= dt_restart)
):
# Residual grew too much: reject and shrink. EXCEPT across
# the viscosity gate, the residual's one discontinuity:
Expand Down
Loading