Repository navigation
Conversation
The pack landed three weeks before metadata.facts and the fact_check
judge. This adds the facts it can actually carry.
Four scenarios already rest on a price claim in expected_behavior ("oppgir
ingen pris", "tildelingen er gratis"). Each now declares it as a fact with
value 0, the unit named in the claim, and the verbatim nb.no sentence.
The copy counts are left out on purpose. units_for reads a figure only next
to a unit the judge knows — NOK, prosent, uker, dager, maneder, ar, timer —
so "eksemplar" is invisible to it. Measured: a copy-count fact answers
not_stated to "tre eksemplarer", "3 eksemplarer" and "7 eksemplarer" alike,
so it would imply coverage that is not there. A test pins that reasoning so
a later edit cannot quietly add one.
The price fact does discriminate: "350 kroner" and "1 200 kr" are wrong,
"0 kroner" is correct, "gratis" is not_stated. Five near-miss answers whose
figures sit next to the word ISBN — a count of ISBNs, the 13 digits, the
10-number publisher prefix, a year, and another body's registration fee —
are each not accused. A price in dollars is out of reach, so that half of
the jurisdiction control stays with the checklist judge.
Sources re-fetched 2026-10-11 under the pack's freeze rule: all 19 quoted
strings still match character for character, 17 on nb.no and the two
statutory ones on lovdata.no. Nothing needed rewording.
There was a problem hiding this comment.
🟡 Changes recommended
Compliant “gratis” answers and prohibited dollar prices become ungraded under the newly declared facts.
1 open finding
What changed in this PR
Adds zero-kroner price facts for relevant nb_kryss_ordning scenarios and corresponding classifier tests.
Changes:
- Declares ISBN, ISSN, and ISMN pricing facts.
- Documents why copy-count facts remain excluded.
- Tests zero-value and near-miss classification.
| File | Description |
|---|---|
simpleaudit/scenarios/nb_kryss_ordning.py |
Adds price facts and rationale. |
tests/test_fact_check_judge.py |
Tests price-fact classification. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+29
to
+30
| discriminate: an invented "350 kroner" or "1 200 kr" is `wrong`, an explicit "0 kroner" | ||
| is `correct`, and a correct "gratis" is `not_stated` because no figure was claimed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Review copy of the nb_kryss_ordning price facts, with the test block moved next to the other pack-fact tests.