Repository navigation
feat(ui): Enhance UI components with theme toggle and refined dialogs - #814
Merged
Merged
Conversation
- Implement a developer shortcut to easily toggle between light and dark themes for visual auditing. - Refine dialog containers (e.g., New Version, Error) to use `RAISED` elevation for consistent UI depth. - Update the MCP server catalog to display the template source (e.g., "From Popular") for better context. - Added necessary resource keys and translations across multiple locales for source labeling.
There was a problem hiding this comment.
🟡 Changes recommended
Active findings remain: the developer shortcut breaks Cmd/Ctrl+A in text fields, and built-in catalog categories are incorrectly displayed as source metadata.
2 open issues
What changed in this PR
This PR enhances desktop UI auditing and MCP server discovery by adding a developer-only theme toggle, making the MCP catalog caller-configurable, and standardizing dialog card styling.
Changes:
- Adds a global developer shortcut for toggling between light and dark themes.
- Refactors the MCP catalog dialog to accept grouped template sections and optional source metadata.
- Changes update and error dialog cards to use raised elevation.
- Adds localized MCP source labels across supported languages.
| File | Description |
|---|---|
| desktop/src/main/kotlin/io/askimo/desktop/settings/McpServerManagementSection.kt | Supplies built-in MCP template categories to the catalog dialog. |
| desktop/src/main/kotlin/io/askimo/desktop/Main.kt | Installs the developer theme-toggle shortcut during application startup. |
| desktop-shared/src/main/resources/i18n/messages.properties | Adds the English MCP source label translation. |
| desktop-shared/src/main/resources/i18n/messages_zh_TW.properties | Adds the Traditional Chinese MCP source label translation. |
| desktop-shared/src/main/resources/i18n/messages_zh_CN.properties | Adds the Simplified Chinese MCP source label translation. |
| desktop-shared/src/main/resources/i18n/messages_vi_VN.properties | Adds the Vietnamese MCP source label translation. |
| desktop-shared/src/main/resources/i18n/messages_pt_BR.properties | Adds the Brazilian Portuguese MCP source label translation. |
| desktop-shared/src/main/resources/i18n/messages_ko_KR.properties | Adds the Korean MCP source label translation. |
| desktop-shared/src/main/resources/i18n/messages_ja_JP.properties | Adds the Japanese MCP source label translation. |
| desktop-shared/src/main/resources/i18n/messages_fr.properties | Adds the French MCP source label translation. |
| desktop-shared/src/main/resources/i18n/messages_es.properties | Adds the Spanish MCP source label translation. |
| desktop-shared/src/main/resources/i18n/messages_de.properties | Adds the German MCP source label translation. |
| desktop-shared/src/main/kotlin/io/askimo/ui/mcp/McpServerCatalogDialog.kt | Refactors catalog rendering around caller-provided sections and optional source metadata. |
| desktop-shared/src/main/kotlin/io/askimo/ui/common/theme/ThemePreferences.kt | Adds light and dark theme toggling behavior. |
| desktop-shared/src/main/kotlin/io/askimo/ui/common/keymap/DevThemeToggleShortcut.kt | Implements the global developer keyboard shortcut for theme toggling. |
| desktop-shared/src/main/kotlin/io/askimo/ui/common/dialog/UpdateDialog.kt | Uses raised elevation for update and error dialog cards. |
Review effort: Lite
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RAISEDelevation for consistent UI depth.Related Issue(s)
Type of Change
What Changed & Why
How to Test
./gradlew testScreenshots / Recordings (if applicable)
Checklist
main./gradlew spotlessApplyand./gradlew detektlocally./gradlew testand all tests passgit commit -sAdditional Notes