Repository navigation
printer.device: pass on the driver's error from PRS_CLOSE - #1850
Open
terminills wants to merge 1 commit into
Open
terminills wants to merge 1 commit into
terminills wants to merge 1 commit into
Conversation
A driver that prints the page when the render is closed (TurboPrint-style drivers, Gutenprint) can only report a failure or a cancelled job from PRS_CLOSE, and its return value was discarded: a cancelled job still completed with io_Error 0. Use it when nothing failed before. The in-tree drivers (postscript, skeleton) return PDERR_NOERR there, so nothing changes for them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A driver that prints the page when the render is closed (TurboPrint-style drivers, Gutenprint) can only report a failure or a cancelled job from PRS_CLOSE, and printer.device discarded that return value: a job the user cancelled still completed with io_Error 0.
This uses the PRS_CLOSE result when nothing failed before. The in-tree drivers (postscript, skeleton) return PDERR_NOERR there, so their behaviour does not change.
Tested on pc-x86_64 in QEMU with the Gutenprint driver and its print preview, PRD_DUMPRPORT from a test program: