Skip to content

Ci/GitHub hosted runners - #236

Merged
shark0F0497 merged 4 commits into
main-v2from
ci/github-hosted-runners
Nov 17, 2026
Merged

shark0F0497 merged 4 commits into
main-v2from
ci/github-hosted-runners

Conversation

@shark0F0497

Copy link
Copy Markdown
Collaborator

Pull Request Checklist

Please ensure your PR meets the following requirements:

  • Code follows the style guidelines
  • Tests pass locally
  • Code is formatted
  • Documentation updated if needed
  • Commit messages follow conventional commits
  • PR description is complete and clear

Summary

This PR adds/fixes/changes [brief description].


Motivation


Changes

Modified Files

  • [file path](file path) - Description of changes
  • [file path](file path) - Description of changes

Added Files

  • [file path](file path) - Description of new file

Deleted Files

  • [file path](file path) - Reason for deletion

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update (documentation changes only)
  • Refactoring (code improvement without functional changes)
  • Performance improvement (code changes that improve performance)
  • Test changes (adding, modifying, or removing tests)

Impact Analysis

Breaking Changes

None

Backward Compatibility

Fully backward compatible


Testing

Test Environment

Test Cases

  • Unit tests pass locally
  • Integration tests pass locally
  • E2E tests pass (if applicable)
  • Manual testing completed

Manual Testing Steps

Test Coverage

  • New tests added
  • Existing tests updated
  • Coverage maintained or improved

Screenshots / Recordings


Performance Impact

  • Memory usage: [No change / Increased / Decreased]
  • CPU usage: [No change / Increased / Decreased]
  • Throughput: [No change / Improved / Regressed]
  • Lock contention: [No change / Reduced / Increased]

Documentation


Related Issues

  • Fixes #
  • Related to #
  • Refers to #

Additional Notes


Reviewers

@reviewer1 @reviewer2


Notes for Reviewers

  • Please review the changes to [specific file]
  • Focus on the concurrency safety of the new implementation
  • Verify the plugin ABI changes are backward compatible

Checklist for Reviewers

  • Code changes are correct and well-implemented
  • Tests are adequate and pass
  • Documentation is updated and accurate
  • No unintended side effects
  • Performance impact is acceptable
  • Backward compatibility maintained (if applicable)

Swap only the runner label (`archebase-ci-runner` -> `ubuntu-latest`) in
the four keystone workflows and keep the existing job containers, CI
scripts and deploy tooling unchanged, so CI capability stays the same.

Because GitHub-hosted runners have no local copy of the job container
image, give each `container:` block the ArcheBase CR credentials so the
runner can pull it. Update the keystone-stack deployment README to match.
The keystone-image job created a per-run Kubernetes BuildKit StatefulSet
and reached it through cluster-internal DNS, which a GitHub-hosted runner
cannot resolve even though it can reach the Kubernetes API server. Build
on the runner's own docker buildx instead and drop the kubectl/BuildKit
plumbing.

Image selection, registry auth, digest reporting and the calibration
repository checkout are unchanged; the job now uses the runner's own
docker/git/jq/ssh tooling instead of the shared job container.
- Create a docker-container buildx builder and cache its exported local
  build cache with actions/cache. Cache export is not available on the
  default docker driver, so builds now run on that builder.
- Keep one local-cache tag per image (keystone, stereo-split, e2/e6
  multimodal conversion, calibration), export with mode=min, and key the
  action cache on the Dockerfiles and dependency manifests.
- Add an allowNonMainV2Branch workflow_dispatch input so the image
  pipeline can be validated from a development branch.
- License job: install reuse from pypi.org. The Tsinghua PyPI mirror
  that worked on the self-hosted runner is unreachable from
  GitHub-hosted runners.
- make helm-lint: render the install path with `helm template` instead
  of `helm install --dry-run=client`. The latter still builds a
  Kubernetes client and fails with "cluster unreachable" when the
  runner has no kubeconfig.
@shark0F0497
shark0F0497 merged commit 97281bd into main-v2 Nov 17, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant