Repository navigation
fix(ci): go 1.26.3, golangci-lint-action v7, lint cleanup, skip windows tests - #2
Merged
Merged
Conversation
3 falhas após os fixes anteriores: - govulncheck achou 2 novas CVEs em net/* do go1.26.2, fixadas em 1.26.3. - golangci-lint-action@v6 nao aceita golangci-lint v2 (precisa v7). - windows-latest: testes em internal/cmd, /commands, /config dependem de HOME env var e perms 0600/0700 (POSIX). Binarios pra Windows continuam sendo publicados pelo goreleaser via cross-compile no Ubuntu — fix dos testes fica pra issue separada. Reverte tambem o `shell: bash` que adicionei pra contornar PowerShell; agora que windows-latest saiu da matrix, nao precisa mais.
golangci-lint v2 (atualizado neste PR de v1.64.5) pegou 5 violacoes pre-existentes no pacote internal/tui que v1 nao reportava: - repl.go e repl_browse.go: arquivos sem gofmt - repl_table.go: parametro title sempre passado como "" (unparam) — remove o parametro e simplifica renderREPLTable; remove tambem plural/itoa que so eram chamados pela ramificacao do title - repl.go: renderTemplatesTable nunca chamada (substituida pelo render no repl_table action handler) — remove a funcao morta - repl_badges.go: sPillBrand declarado mas nunca usado — remove Build e tests passam, govulncheck zerou apos bump pra go 1.26.3.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PR #1 ja foi mergeado, mas o CI em main continua vermelho. Estes 2 commits resolvem:
fix(ci): go 1.26.3, golangci-lint-action v7, skip windows tests(fe23291)net/*(GO-2026-4971, GO-2026-4918) — fix em 1.26.3HOMEenv var e perms0600/0700(POSIX). Binarios pra Windows continuam publicados pelo goreleaser via cross-compile no Ubuntu. Fix dos testes Windows fica pra issue separada.chore(tui): fix lint issues exposed by golangci-lint v2(b3d4e29)5 violacoes pre-existentes em
internal/tui/*que o golangci-lint v1.64.5 nao reportava:repl.go+repl_browse.go: gofmtrepl_table.go: parametrotitleemrenderREPLTablesempre passado como""(unparam) — remove o parametrorepl_table.go:pluraleitoaeram chamados so pela ramificacao dotitle— removerepl.go:renderTemplatesTablesubstituida pelo render no action handler — remove a funcao mortarepl_badges.go:sPillBranddeclarado mas nunca usado — removeLocal validation
go build ./...cleango test -race ./...13/13 packages OKgolangci-lint run0 issuesgovulncheck ./...0 vulnerabilitiesBloqueia
Release v0.1.0. Sem este merge, o CI permanece vermelho em main e bloqueia subir release.
🤖 Generated with Claude Code