Repository navigation
fix: compare reloaded state exactly and outputs with tolerance - #174
Merged
NehalBhandari merged 2 commits intoOct 30, 2026
Merged
NehalBhandari merged 2 commits into
NehalBhandari merged 2 commits into
Conversation
The state-dict reload tests from apple#157 required bitwise-equal forward outputs, which fails intermittently on 1-ulp kernel differences. Assert the reloaded state dict matches exactly instead, and compare outputs with default tolerances.
dengqiaoyu
approved these changes
Oct 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relax the forward-output checks of the state-dict reload tests added in #157 from bitwise equality to the default
assert_closetolerances, and assert that the reloaded state dict matches the source exactly instead.