Repository navigation
Conversation
- Adds `DelegatedCredentials` and `RecordSizeLimit` to `ExtensionType`, and lists every extension in the firefox128/133/135/144 `extension_order`. Five extensions were missing from those lists, so they were shuffled on every connection and JA3 changed per request. The order is now fixed and matches real Firefox; JA4 is unchanged. - `record_size_limit` is 16385 (0x4001) in firefox133/135/144, not 4001. - firefox128: real Firefox 128's cipher order, and P-521 in `supported_groups`. Adds tests that build each Firefox profile's ClientHello and compare it with real Firefox's JA3 and `record_size_limit`. Part of apify#576 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #576.
extension_orderleft out five extensions, so they were shuffled on every connection and JA3 changed per request. This addsDelegatedCredentialsandRecordSizeLimittoExtensionTypeand completes the lists from real Firefox 128/133/135/144 captures. The order is now fixed and JA3 matches real Firefox; JA4 is unchanged.record_size_limitis 16385 in firefox133/135/144 (was 4001).supported_groups.A new test builds each Firefox profile's ClientHello and checks it against real Firefox's JA3.