Repository navigation
Conversation
vdusek
added
adhoc
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1151 +/- ##
==========================================
+ Coverage 95.49% 95.53% +0.03%
==========================================
Files 61 61
Lines 5947 5975 +28
==========================================
+ Hits 5679 5708 +29
+ Misses 268 267 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
vdusek
added a commit
to apify/apify-docs
that referenced
this pull request
Oct 19, 2026
Aligns the Actor, version, env var and schedule request schemas with what the API accepts, checked against apify-core and the live API. `CreateActorRequest` gets `actorPermissionLevel` and `CreateOrUpdateScheduleRequest` gets `notifications`, which now has its own `ScheduleNotifications` schema. Fields drop `null` where the API rejects it, or where a stored `null` breaks later requests. `versions` needs at least one item. `CreateOrUpdateVersionRequest` is split into `CreateVersionRequest`, which requires `versionNumber` and `sourceType`, and `UpdateVersionRequest`, where everything stays optional. Both take a new `WritableVersionSourceType` enum without `SOURCE_CODE`, which the API rejects. `EnvVarRequest` is now a standalone schema that requires `name` and `value`. The previous `allOf` over `EnvVar` made the generated client report an invalid override (apify/apify-client-python#1150). Value patterns and length limits are left out on purpose: apify-client-python turns them into local validation that would reject input before the API sees it. apify/apify-client-python#1151 previews the regenerated models. Until they're regenerated, apify/apify-client-python#1144 adds the missing fields to the request body by hand. *✍️ Drafted by Claude Code*
Contributor
Author
|
closing as this was only tmp draft for review changes in apify-docs |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preview of the models generated from apify/apify-docs#3087, so we can see what that spec change does to the client before it merges. Not meant to be merged: the models come from a locally bundled spec, and the nightly regeneration will produce the real ones once the docs PR is deployed.
The baseline spec (the docs PR's merge base) reproduces
master's models exactly, so the whole diff comes from that PR. The three resource clients that usedCreateOrUpdateVersionRequestnow useCreateVersionRequestorUpdateVersionRequest.The docs PR leaves out value patterns and length limits on purpose, because the client would enforce them locally. The only new client-side checks are the required
version_numberandsource_typeonCreateVersionRequest, the requirednameandvalueonEnvVarRequest, and at least one item inversions.✍️ Drafted by Claude Code