Skip to content

feat: add missing optional parameters to resource clients - #1144

Draft
vdusek wants to merge 1 commit into
masterfrom
feat/missing-resource-client-params
Draft

vdusek wants to merge 1 commit into
masterfrom
feat/missing-resource-client-params

Conversation

@vdusek

@vdusek vdusek commented Oct 16, 2026 •

Copy link
Copy Markdown
Contributor

Adds optional parameters that the API accepts and the JS client already exposes:

  • Task create() / update(): description, max_total_charge_usd
  • Webhook create() / update(): description, should_interpolate_strings
  • Schedule create() / update(): notifications_email (sent as notifications.email)
  • Store list() / iterate(): include_unrunnable_actors
  • Actor create(): actor_permission_level
  • Dataset, key-value store and request queue update(): title
  • Dataset: flatten and view on iterate_items(), view and attachment on get_items_as_bytes() and stream_items(), item_format on create_items_public_url()

Blocked by apify/apify-docs#3087. notifications and actor_permission_level are missing from the generated request models, so this PR adds them to the request body by hand for now. Once that spec PR merges and the models are regenerated, they go through the models. Task input stays dict-only: the spec allows a list, but the API rejects anything other than an object.

Closes: #1147

✍️ Drafted by Claude Code

@vdusek vdusek added adhoc Ad-hoc unplanned task added during the sprint. t-tooling Issues with this label are in the ownership of the tooling team. labels Oct 16, 2026
@vdusek vdusek self-assigned this Oct 16, 2026
@codecov

codecov Bot commented Oct 16, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.46%. Comparing base (53a9954) to head (af19452).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1144      +/-   ##
==========================================
+ Coverage   95.43%   95.46%   +0.03%     
==========================================
  Files          61       61              
  Lines        5935     5953      +18     
==========================================
+ Hits         5664     5683      +19     
+ Misses        271      270       -1     
Flag Coverage Δ
integration 90.89% <78.57%> (+0.09%) ⬆️
unit 89.66% <100.00%> (+0.78%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@vdusek vdusek removed the adhoc Ad-hoc unplanned task added during the sprint. label Oct 16, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t-tooling Issues with this label are in the ownership of the tooling team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add missing optional parameters to resource clients

2 participants