Skip to content

fix: rename build_tag to build in validate_input() - #1110

Merged
vdusek merged 1 commit into
masterfrom
refactor/validate-input-build
Oct 8, 2026
Merged

vdusek merged 1 commit into
masterfrom
refactor/validate-input-build

Conversation

@vdusek

@vdusek vdusek commented Oct 8, 2026

Copy link
Copy Markdown
Contributor

ActorClient.validate_input() and its async twin now take the build as build, the same name start(), call() and the JS client's validateInput() use.

build_tag still works as a deprecated alias. It emits a DeprecationWarning and will be removed in v4. Passing both build and build_tag raises a ValueError. The warning uses stacklevel=3 because the logging wrapper adds a frame, so it points at the caller's code.

Closes: #1091

✍️ Drafted by Claude Code

@vdusek vdusek added the t-tooling Issues with this label are in the ownership of the tooling team. label Oct 8, 2026
@vdusek vdusek self-assigned this Oct 8, 2026
@codecov

codecov Bot commented Oct 8, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.41%. Comparing base (966d3d6) to head (371f4d6).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1110   +/-   ##
=======================================
  Coverage   95.40%   95.41%           
=======================================
  Files          61       61           
  Lines        5880     5891   +11     
=======================================
+ Hits         5610     5621   +11     
  Misses        270      270           
Flag Coverage Δ
integration 91.02% <27.27%> (-0.23%) ⬇️
unit 88.47% <100.00%> (+0.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@vdusek
vdusek marked this pull request as ready for review October 8, 2026 08:22
@vdusek
vdusek requested a review from Mantisus October 8, 2026 08:22
@apify-service-account apify-service-account added the tested Temporary label used only programatically for some analytics. label Oct 8, 2026

@Mantisus Mantisus left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@apify-approval-mirror apify-approval-mirror Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mirroring approval from @Mantisus.

@vdusek vdusek changed the title refactor: rename build_tag to build in validate_input() fix: rename build_tag to build in validate_input() Oct 8, 2026
@vdusek
vdusek merged commit 0616e1a into master Oct 8, 2026
34 checks passed
@vdusek
vdusek deleted the refactor/validate-input-build branch October 8, 2026 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t-tooling Issues with this label are in the ownership of the tooling team. tested Temporary label used only programatically for some analytics.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rename build_tag to build in validate_input()

3 participants