Skip to content

perf: default gzip compression quality to 6 - #1099

Merged
vdusek merged 2 commits into
masterfrom
fix/gzip-default-quality
Oct 7, 2026
Merged

vdusek merged 2 commits into
masterfrom
fix/gzip-default-quality

Conversation

@vdusek

@vdusek vdusek commented Oct 7, 2026

Copy link
Copy Markdown
Contributor

GzipHttpCompressor now defaults to quality 6 instead of 9. Level 6 is zlib's own default and what the JS client uses. Levels above 6 take about twice the CPU for request bodies roughly a percent smaller. Passing quality=9 explicitly still works.

Closes: #1095

✍️ Drafted by Claude Code

@vdusek vdusek added the t-tooling Issues with this label are in the ownership of the tooling team. label Oct 7, 2026
@vdusek vdusek self-assigned this Oct 7, 2026
@codecov

codecov Bot commented Oct 7, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.40%. Comparing base (6aa8ead) to head (66f1151).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1099   +/-   ##
=======================================
  Coverage   95.40%   95.40%           
=======================================
  Files          61       61           
  Lines        5880     5880           
=======================================
  Hits         5610     5610           
  Misses        270      270           
Flag Coverage Δ
integration 91.13% <100.00%> (+0.08%) ⬆️
unit 88.35% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@vdusek
vdusek requested a review from Mantisus October 7, 2026 11:43
@vdusek
vdusek marked this pull request as ready for review October 7, 2026 11:43
@vdusek
vdusek requested a review from szaganek as a code owner October 7, 2026 11:43
@apify-service-account apify-service-account added the tested Temporary label used only programatically for some analytics. label Oct 7, 2026

@Mantisus Mantisus left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@apify-approval-mirror apify-approval-mirror Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mirroring approval from @Mantisus.

@vdusek
vdusek merged commit 00cfb65 into master Oct 7, 2026
32 checks passed
@vdusek
vdusek deleted the fix/gzip-default-quality branch October 7, 2026 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t-tooling Issues with this label are in the ownership of the tooling team. tested Temporary label used only programatically for some analytics.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Default gzip compression quality to 6

3 participants