Repository navigation
fix: page offset iterators past the first page's total - #1125
Merged
Merged
Conversation
Closes #1117 BREAKING CHANGE: iterating a `list()` method or `listItems()` no longer stops at the `total` reported by the first page. It pages until a page scans no rows or the caller's `limit` is reached, which takes one more request at the end.
vdusek
added
the
t-tooling
Contributor
|
See more at https://github.com/apify/apify-client-js/actions/runs/37583957298#summary-112669732087 |
vdusek
marked this pull request as ready for review
October 7, 2026 06:55
vdusek
changed the title
vdusek
changed the title
apify-service-account
added
the
tested
Contributor
Author
vdusek
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Offset iterators (
list(),listItems()) stopped at the first page'stotal, so rows pushed during the loop were never read. They now page until a page scans no rows orlimitis reached, like the Python client. Each page advances by the larger ofx-apify-pagination-countanditems.length, capped at the requested limit, because the header lags a fresh push.Loosely related to #1085:
RunClient.iterateDatasetItems()stays the tool for reading a dataset a run is still writing.Closes: #1117
✍️ Drafted by Claude Code