Repository navigation
feat(init): warn when a Python project has no Dockerfile - #1506
Closed
patrikbraborec wants to merge 2 commits into
Closed
patrikbraborec wants to merge 2 commits into
patrikbraborec wants to merge 2 commits into
Conversation
Contributor
Author
|
Closing: a warning that only covers Python packages misses most cases (Python with a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
apify initdoesn't create a Dockerfile. When a Python project has none, the platform builds it from the defaultapify/actor-node:24image. The build succeeds, and the Actor then fails at runtime in a confusing way. This came up during Devin plugin testing.apify initnow warns when it detects a Python project with no Dockerfile. It checks the--dockerfileflag, theactor.jsondockerfilefield,.actor/Dockerfileand a rootDockerfile, which is the platform's lookup order.update-docs. No dependency changes.Related: #1479 and #1330 fix the other
initproblems from the same testing (--yesnot skipping the name prompt, and the hang without a TTY).