Skip to content

chore(generic): run Actors on patched Node 24.22.1 - #376

Merged
nikitachapovskii-dev merged 2 commits into
masterfrom
chore/patched-node-base-images
Oct 27, 2026
Merged

nikitachapovskii-dev merged 2 commits into
masterfrom
chore/patched-node-base-images

Conversation

@nikitachapovskii-dev

Copy link
Copy Markdown
Contributor

context:
https://apify.slack.com/archives/C033WM3PXLK/p1793005065507339

Puppeteer and Web Scraper move to the 24-25.16.0 base with puppeteer 25.16.0. Playwright (held at 1.61.1) and Camoufox (held at 1.59.1) keep their bases, which Apify no longer rebuilds, and get the node binary from node:24.22.1-trixie-slim. Cheerio, JSDOM and Sitemap use the floating apify/actor-node:24 tag and only need a rebuild.

@coderabbitai

coderabbitai Bot commented Oct 26, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters: 1
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml, !pnpm-lock.yaml

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Central YAML; Path: .coderabbit.yaml
  • Review profile: CHILL
  • Plan: Essentials
  • Run ID: faf4a2eb-fc20-4e83-b5f0-c54658efc0e9

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

No actionable comments were generated in the recent review.

Recent review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Central YAML; Path: .coderabbit.yaml
  • Review profile: CHILL
  • Plan: Essentials
  • Run ID: 81cc2dcd-d94d-4397-92eb-5a61f4712f4d
Commits

Reviewing files that changed from the base of the PR and between e89952c and c7a71c2.

Files ignored due to path filters: 1
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml, !pnpm-lock.yaml
Files selected for processing: 2
  • packages/actor-scraper/camoufox-scraper/Dockerfile
  • packages/actor-scraper/playwright-scraper/Dockerfile

Included review availability: This review used your included allowance. 0 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 5 reviews per hour.

Walkthrough

Puppeteer dependencies and builder/runtime images for the Puppeteer and web scrapers change from version 25.4.0 to 25.16.0. The root development dependency changes to 25.16.0. Camoufox and Playwright runtime stages copy the Node 24.22.1 binary from a pinned image, replacing the base image’s Node binary.

Priority: Normal

Merge Risk: Minimal · previous review c7a71

The runtime and Puppeteer updates are consistent and present no identified merge-blocking risk.

Pre-merge checks: Passed 4
Check name Status Explanation
Description check Passed The description accurately summarizes the Node.js, Puppeteer, Playwright, Camoufox, and related base-image changes. It is directly related to the changeset.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Title check Passed The title clearly states the primary change: running Actors on patched Node 24.22.1. It is concise and consistent with the Dockerfile updates.
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

Puppeteer and Web Scraper move to the 24-25.16.0 base with puppeteer 25.16.0. Playwright and Camoufox stay on their held bases and take node from node:24.22.1-trixie-slim. Cheerio, JSDOM and Sitemap only need a rebuild.
@nikitachapovskii-dev
nikitachapovskii-dev force-pushed the chore/patched-node-base-images branch from e89952c to c7a71c2 Compare October 26, 2026 09:57
@nikitachapovskii-dev

nikitachapovskii-dev commented Oct 26, 2026 •

Copy link
Copy Markdown
Contributor Author

@barjin this also affects the jsdom and camoufox scrapers.
Please decide whether you are ok with the bump for them or you want to skip it for now. Thanks!

@nicklamonov nicklamonov linked an issue Oct 26, 2026 that may be closed by this pull request
@nikitachapovskii-dev nikitachapovskii-dev changed the title fix(generic): run Actors on patched Node 24.22.1 (Brotli RCE) chore(generic): run Actors on patched Node 24.22.1 (Brotli RCE) Oct 27, 2026

@barjin barjin left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, let's do it for all the Actors (can you please bump the versions in jsdom / linkedom as well in this PR? I'll deal with the releases afterwards 👍 )

Thanks @nikitachapovskii-dev !

@nikitachapovskii-dev nikitachapovskii-dev changed the title chore(generic): run Actors on patched Node 24.22.1 (Brotli RCE) chore(generic): run Actors on patched Node 24.22.1 Oct 27, 2026
@nikitachapovskii-dev
nikitachapovskii-dev merged commit ecc1b08 into master Oct 27, 2026
4 checks passed
@nikitachapovskii-dev
nikitachapovskii-dev deleted the chore/patched-node-base-images branch October 27, 2026 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Actor security update for generic scrapers

4 participants