fix(jsonschema): handle partial update required properties - #8484
Closed
JakovKnezovicc wants to merge 1 commit into
Closed
fix(jsonschema): handle partial update required properties#8484JakovKnezovicc wants to merge 1 commit into
JakovKnezovicc wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
A POST and a standard PUT can reuse the same schema definition when their input requirements match. However, a PUT configured with standard_put: false represents a partial update, so it must not inherit the required properties
from that shared definition.
What changed
The schema factory now identifies non-standard PUT operations as partial updates. Only those schemas receive a distinct .partial definition name and omit required properties. Standard PUT and POST schemas continue reusing the
same definition when appropriate.
Result
The generated schema reflects the configured PUT behavior accurately without creating unnecessary duplicate definitions. Tests cover both definition reuse and partial-update behavior.