[SYSTEMDS-3970] Obtain Nnz Information of Reads before Rewriting Main Program Block - #2606
Open
ywcb00 wants to merge 3 commits into
Open
[SYSTEMDS-3970] Obtain Nnz Information of Reads before Rewriting Main Program Block#2606ywcb00 wants to merge 3 commits into
ywcb00 wants to merge 3 commits into
Conversation
…write rule to split off permanent reads into a dedicated statement block such that we can use the sparsity information about this data in the main statment block feat(main/hops/rewrite/ProgramRewriter.java): add the new rewrite rule to the set of applied rewriters
…add unit test for splitting the statement block due to unknown sparsity of permanent read feat(test/scripts/functions/rewrite/RewriteSplitDagUnknownNnz.dml): add dml script for unit test
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #2606 +/- ##
============================================
- Coverage 71.39% 71.38% -0.02%
- Complexity 50539 50664 +125
============================================
Files 1632 1639 +7
Lines 196237 196864 +627
Branches 38201 38276 +75
============================================
+ Hits 140113 140541 +428
- Misses 45099 45259 +160
- Partials 11025 11064 +39 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
This PR adds the rewriting functionality to split a permanent read operation into a separate, preceding statement block if the meta data of the read object does not provide information about its number of non-zeros beforehand. By performing the read separately, the sparsity information can already be leveraged when recompiling the main program block.
The PR also adds a flag to disable and enable this new feature (disabled by default) as well as unit tests to cover the functionality.
All the best,
David