fix: only update metadata enable status within the same namespace (#6615) - #7047
Open
wy471x wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make sure that:
./mvnw clean install -Dmaven.javadoc.skip=true.Summary
Fixes #6615.
MetaDataServiceImpl.enabledByIdsAndNamespaceIdchecked existence with a namespace-scoped query but passed the caller-supplied rawidstoMetaDataMapper.updateEnableBatch, whose SQL only filters byid IN (...). A caller scoped to one namespace could therefore enable/disable metadata rows that belong to another namespace.Changes
MetaDataServiceImpl.enabledByIdsAndNamespaceId(shenyu-admin/src/main/java/org/apache/shenyu/admin/service/impl/MetaDataServiceImpl.java:132) —updateEnableBatchnow receives only the ids of the rows returned by the namespace-scopedselectByIdListAndNamespaceIdquery (ListUtil.map(metaDataDoList, MetaDataDO::getId)) instead of the raw request ids. Mapper SQL and event publishing behavior are unchanged.Test Cases
MetaDataServiceTest.testEnabledOnlyUpdatesIdsWithinNamespace— verifies that when the request contains ids belonging to another namespace but the scoped select returns only the current namespace's row,updateEnableBatchandonEnabledonly receive the current namespace's id.Verification
./mvnw -pl shenyu-admin clean install -Dmaven.javadoc.skip=true -Dtest=org.apache.shenyu.admin.service.MetaDataServiceTest -DfailIfNoTests=false— BUILD SUCCESS; Tests run: 16, Failures: 0, Errors: 0, Skipped: 0.close #6615