Skip to content

Fix bytes pk for dim tables - #19501

Open
RajaVinoth96 wants to merge 5 commits into
apache:masterfrom
RajaVinoth96:fix_bytes_pk_for_dim_tables
Open

Fix bytes pk for dim tables#19501
RajaVinoth96 wants to merge 5 commits into
apache:masterfrom
RajaVinoth96:fix_bytes_pk_for_dim_tables

Conversation

@RajaVinoth96

@RajaVinoth96 RajaVinoth96 commented Sep 7, 2026

Copy link
Copy Markdown

PR flow

Wrap byte array primary keys with ByteArray before lookup in dimension tables.

flowchart TD
  N0["call wrapPrimaryKey in createFastLookupDimensionTable #40;F1#41;"]:::stAdded
  N1["call wrapPrimaryKey in createMemOptimisedDimensionTable #40;F1#41;"]:::stAdded
  N2["wrapPrimaryKey#58; convert byte#91;#93; elements to ByteArray #40;F1#41;"]:::stAdded
  N0 -->|"calls"| N2
  N1 -->|"calls"| N2
  classDef stAdded fill:#dafbe1,stroke:#1a7f37,color:#1f2328,stroke-width:2px
  classDef stModified fill:#fff8c5,stroke:#9a6700,color:#1f2328,stroke-width:2px
  classDef stRemoved fill:#ffebe9,stroke:#cf222e,color:#1f2328,stroke-width:2px
  classDef stUnchanged fill:#f6f8fa,stroke:#656d76,color:#1f2328,stroke-width:1px
Loading

AI-generated · Green: added · Yellow: modified · Red: removed · Gray: existing

Diff evidence
  • F1: pinot-core/src/main/java/org/apache/pinot/core/data/manager/offline/DimensionTableDataManager.java — before · after
  • Regenerate PR flow

Fixes 19228. Adding tests on top of @waterWang 's changes

@RajaVinoth96

Copy link
Copy Markdown
Author

@yashmayya @Jackie-Jiang Can you please review?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BYTES primary key columns in dimension tables can never be looked up

2 participants