[spark] Convert EqualNullSafe(NaN) to isNaN in V2 filters - #9720
Merged
Conversation
JingsongLi
reviewed
Sep 11, 2026
JingsongLi
left a comment
Contributor
There was a problem hiding this comment.
This has end-to-end value: Spark's f <=> NaN must retain NaN rows through Paimon pruning. Using IsNaN matches the existing = conversion; its row evaluation rejects NULL and its statistics evaluation remains conservative. I also checked the NOT path: IsNaN.negate() is unsupported, so conversion falls back instead of introducing incorrect negated pushdown.
No blocking issue found in this focused source review. The added FLOAT/DOUBLE SQL cases cover the intended result and nonempty scan. I have not rerun the Spark suite locally.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Tests
Added
V2Filter: EqualNullSafe NaNtoSparkV2FilterConverterTestBase.