feat(file_index): generate indexes for append writes - #819
Open
QuakeWang wants to merge 2 commits into
Open
Conversation
Build configured Bitmap and Bloom Filter indexes per append data file and record embedded or sidecar indexes in commit metadata. Clean up failed indexed writes and verify pruning through committed table reads. Signed-off-by: QuakeWang <wangfuzheng0814@foxmail.com>
JingsongLi
reviewed
Sep 12, 2026
| row_kind_generator: Option<RowKindGenerator>, | ||
| row_kind_filter: Option<RowKindFilter>, | ||
| file_index_options: Option<Arc<FileIndexOptions>>, | ||
| indexed_write_failed: bool, |
Member
Author
There was a problem hiding this comment.
This was an unnecessary defensive check to prevent writer reuse after a failure. Removed in 2fa63e3; error propagation and file cleanup are preserved.
Remove index-specific failure flags and reuse guards while retaining error propagation and cleanup of newly created files. Update the cleanup test and documentation to reflect this behavior. Signed-off-by: QuakeWang <wangfuzheng0814@foxmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Closes #818.
Rust can read FileIndexes, but ordinary append writes leave index metadata empty. This change generates configured indexes during append writes so committed files can benefit from FileIndex pruning.
Brief change log
Tests
fulltext,vortexpassed (2968 passed, 2 ignored).API and Format
No public API or index format changes. Reuses existing FileIndex serialization and metadata; generation is limited to ordinary append writes.
Documentation
Added append FileIndex configuration and scope to the getting-started guide.