Add Kotoba v1 ORC header/magic binding - #2708
Open
com-junkawasaki wants to merge 3 commits into
Open
Conversation
Introduce a sibling kotoba/ tree that compiles with Kotoba 0.7.2 to wasm32 i64-v1 and parses only file magic plus uncompressed postscript/footer fields on a 42-byte vendored fixture. This is not a C++/Java reader replacement and does not decode stripes. Co-authored-by: Jun Kawasaki <04.feasts_minded@icloud.com>
Those files are not required to compile or run the Kotoba header fixture. Keep this change to kotoba/ and the kotoba CI workflow. Co-authored-by: Jun Kawasaki <04.feasts_minded@icloud.com>
Parse kotoba compile --json and fail unless kotoba.cli/ok? is true and kotoba.cli/code is emitted. Fail if the wasm has an import section. Keep the header fixture asserts. Ignore kotoba paths on Build and test and Address/Undefined Sanitizer Tests. Co-authored-by: Jun Kawasaki <04.feasts_minded@icloud.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a first-class
kotoba/sibling next toc++/andjava/.What this is
v1 reader for ORC file magic plus an uncompressed postscript/footer on a 42-byte vendored fixture. Reports stripe count and the first struct field name. Compiles to host-independent wasm32 with kotoba CLI v0.7.2 (no FFI, no IEEE floats).
What this is not
Checks
kotoba/checks.shcompiles the module and asserts those header fields. Fork Kotoba workflow on kotoba-lang#1 ran the compile + fixture job.ASF ICLA may apply for this contribution. This PR does not file ICLA.
Fork PR: kotoba-lang#1