Repository navigation
Fix Maven 4 @Mojo descriptor attributes - #1237
Open
efegokdemir wants to merge 1 commit into
Open
efegokdemir wants to merge 1 commit into
efegokdemir wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1231.
What
onlineRequired,dependencyCollection, anddependencyResolutionPathScopesannotation attributes during descriptor extraction.dependencyCollectionwhen collection is requested, and todependencyResolutionotherwise.Why
The annotation scanner dispatches attributes to same-named setters on
MojoAnnotationContent. The missing setters made thedescriptorgoal fail when Maven 4 annotation attributes were explicitly set. The path scopes also need to be retained in the matching Maven 4 descriptor field.Testing
v4api-4xintegration fixture failed during descriptor generation withMethod: 'dependencyResolutionPathScopes' not found.JAVA_HOME=/opt/homebrew/opt/openjdk@17/libexec/openjdk.jdk/Contents/Home /tmp/maven4-rc7/apache-maven-4.0.0-rc-7/bin/mvn -pl maven-plugin-plugin -am -Prun-its -Dinvoker.test=v4api-4x -DskipTests verify— PASS; the Maven 4v4api-4xintegration test passed.JAVA_HOME=/opt/homebrew/opt/openjdk@17/libexec/openjdk.jdk/Contents/Home /opt/homebrew/Cellar/maven/3.10.0/libexec/bin/mvn -pl maven-plugin-tools-annotations -am test— PASS; 98 tests, no failures or errors.git diff --cached --check— PASS.Notes
AI assistance was used during preparation; the submitting contributor reviewed the changes and test results.