Repository navigation
Conversation
gnodet-bot
approved these changes
Oct 9, 2026
gnodet-bot
left a comment
gnodet-bot
left a comment
There was a problem hiding this comment.
LGTM. Clean, minimal fix for the module source hierarchy deploy failure. Pre-fix test validation confirmed: the new test fails without the fix (directory main artifact stays in the deploy request) and passes with it. All 50 existing tests remain green.
This review was generated by an AI agent, Hermès on behalf of @gnodet.
…archy) A project built with the Maven 4 module source hierarchy produces one JAR per Java module, attached as separate artifacts, and never assigns a file to the main artifact -- its path stays the (directory) build output. With allowIncompleteProjects=true the deploy goal warned about the missing main file but still passed the directory to the deployer, which failed with "is a folder". Drop the main artifact from the deploy request in that case and deploy the POM and the attached per-module JARs only. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
ascheman
force-pushed
the
bugfix/msh-deploy-is-a-folder
branch
from
October 9, 2026 23:11
d6ab412 to
7817bc1
Compare
2 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a project uses the Maven 4 module source hierarchy, the JAR plugin produces one JAR per Java module and attaches them as separate artifacts, without assigning a file to the project's main artifact — its path stays the (directory) build output.
With
allowIncompleteProjects=true,deploywarned about the missing main file but still passed the directory to the deployer, which failed:(reported by @desruisseaux while building apache/sis.)
This drops the main artifact from the deploy request in that case and deploys the POM + the attached per-module JARs only. A new
DeployMojoTestcase asserts the directory main artifact is excluded from the request (it fails without this change).The existing "change packaging to 'pom'" warning is kept as-is for minimality; it now reads a bit oddly since the attachments deploy successfully — happy to reword if preferred.