Repository navigation
fix(code-review): keep export-ignore paths in the adversarial export - #2030
Merged
Merged
Conversation
git archive honours export-ignore, so a project that marks a directory that way lost it from the reviewers' export, even when the PR changed files there. Export through a temporary index instead, forcing the removal of the vetted-ops policy path, which a PR may change. Generated-by: Claude Opus 5
potiuk
added a commit
that referenced
this pull request
Nov 10, 2026
Brings the specs up to main bfc99bb (37 commits since 1e5c4f9), ahead of the next dev-version bump: - security-issue-lifecycle: the import renders the report as defanged markdown under a data note, with `description_format: inert` as the fenced alternative (#2048). - adapters: oauth-draft threading by explicit In-Reply-To / References (#2051); the typed-decision Jev request shape (#2023). - adoption-and-setup, marketplace-distribution, codex-runtime: the setup sub-action is `update`, and every skill offers the upgrade until it has run (#2041); the most specific `sandbox.enabled` wins (#2011); the family MCP allows cover single-item reads only (#2020). - agent-isolation-sandbox: bare `gh auth status` only (#2019); draft creation and whole-mailbox search stay prompted (#2020). - pr-management-family: the CI gate's way out for a non-required check (#2029); the adversarial export keeps export-ignore paths (#2030); install.md per family (#2031); merge-candidates / thread-mentor names (#2025). - contributor-growth: the candidate-screen committer / PMC headline (#2024). - issue-management-family, repo-health-family: install.md (#2031). - project-agnosticism: the merge-candidates example path and a re-counted example-name gap (#2025). Generated-by: Claude Opus 5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
adversarial.mdexports the PR head withgit archive, which honoursexport-ignore. A project that marks a directory that way loses it from the export with no warning, even when the PR changes files there, so the reviewers cannot read the surrounding code.read-tree,rm --cached,checkout-index), which ignoresexport-ignoreand still drops the vetted-ops policy path.Seen on apache/airflow#76510:
dev/isexport-ignorethere, so the export was missing every file the PR changed.Type of change
.claude/skills/<name>/) — eval fixtures updated belowTest plan
prek run --files <changed files>passesdev/was exported, and the checkout and its real index were untouchedgit rmwithout-ffails, and with-fthe export keeps theexport-ignoredirectory and drops the policy fileRFC-AI-0004 compliance
Linked issues
Refs #1986.
Notes for reviewers
An adversarial reviewer flagged that
checkout-indexapplies smudge filters. So doesgit archive: on a test repository with a smudge filter both exported the same filtered content, so this change neither adds nor removes that exposure.🤖 Generated with Claude Code