Repository navigation
fix(code-review): name the way out when a non-required check holds the CI gate - #2029
Merged
Merged
Conversation
…e CI gate When a pending check that is not required kept the CI gate, disposition set no ci_action. The documented release after approval cannot help there, since release-runs needs the approval this gate withholds. Point at waiting or approving the held runs through pr-management-triage, and give approve-workflow the re-run fallback for runs that answer 403. Generated-by: Claude Opus 5
potiuk
added a commit
that referenced
this pull request
Nov 10, 2026
Brings the specs up to main bfc99bb (37 commits since 1e5c4f9), ahead of the next dev-version bump: - security-issue-lifecycle: the import renders the report as defanged markdown under a data note, with `description_format: inert` as the fenced alternative (#2048). - adapters: oauth-draft threading by explicit In-Reply-To / References (#2051); the typed-decision Jev request shape (#2023). - adoption-and-setup, marketplace-distribution, codex-runtime: the setup sub-action is `update`, and every skill offers the upgrade until it has run (#2041); the most specific `sandbox.enabled` wins (#2011); the family MCP allows cover single-item reads only (#2020). - agent-isolation-sandbox: bare `gh auth status` only (#2019); draft creation and whole-mailbox search stay prompted (#2020). - pr-management-family: the CI gate's way out for a non-required check (#2029); the adversarial export keeps export-ignore paths (#2030); install.md per family (#2031); merge-candidates / thread-mentor names (#2025). - contributor-growth: the candidate-screen committer / PMC headline (#2024). - issue-management-family, repo-health-family: install.md (#2031). - project-agnosticism: the merge-candidates example path and a re-counted example-name gap (#2025). Generated-by: Claude Opus 5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dispositionkeeps the CI gate but sets noci_action, so the maintainer getsCOMMENTand no next step.disposition-auto-merge.mdreleases held runs after the approval, andrelease-runsrefuses without anAPPROVEDreview, which this gate withholds. Fixup + approve + auto-merge therefore cannot proceed.dispositionnow setsci_actionfor this gate: wait for the checks, or approve held runs throughpr-management-triage, then re-run it.disposition-auto-merge.mdstates the same exception.approve-workflow.mdonly called the approve endpoint, so a held run from a returning contributor, which answers HTTP 403, had no way forward there. It now has the re-run fallback thatcode_review/runs.pyalready documents.Seen on apache/airflow#76510, where the pending checks were
Workflow approval,Fork CI gateand two others. Approving through triage and waiting for CI cleared the gate.Type of change
.claude/skills/<name>/) — eval fixtures updated belowtools/*/withpyproject.toml)Test plan
prek run --files <changed files>passes; it updated the plugin copy ofdisposition.pyuv run pytest tests/code_reviewpasses intools/pr-managementtest_ci_that_never_ran_names_the_workflow_actioncase fails without the changeRFC-AI-0004 compliance
Linked issues
Refs #1951.
Notes for reviewers
The gate and the release order are unchanged on purpose.
release-runsrequires an approval because releasing a run executes the head's code in CI, and this gate exists because auto-merge would not wait for those checks. Whether held runs should get their own path throughdispositionis a larger question; this only removes the dead end.🤖 Generated with Claude Code