Skip to content

fix(code-review): name the way out when a non-required check holds the CI gate - #2029

Merged
potiuk merged 1 commit into
apache:mainfrom
potiuk:fix/code-review-held-runs-gate
Nov 9, 2026
Merged

potiuk merged 1 commit into
apache:mainfrom
potiuk:fix/code-review-held-runs-gate

Conversation

@potiuk

@potiuk potiuk commented Nov 9, 2026

Copy link
Copy Markdown
Member

Summary

  • When a held workflow run shows up as a pending check that is not required, disposition keeps the CI gate but sets no ci_action, so the maintainer gets COMMENT and no next step.
  • The documented way out does not apply there: disposition-auto-merge.md releases held runs after the approval, and release-runs refuses without an APPROVED review, which this gate withholds. Fixup + approve + auto-merge therefore cannot proceed.
  • disposition now sets ci_action for this gate: wait for the checks, or approve held runs through pr-management-triage, then re-run it. disposition-auto-merge.md states the same exception.
  • approve-workflow.md only called the approve endpoint, so a held run from a returning contributor, which answers HTTP 403, had no way forward there. It now has the re-run fallback that code_review/runs.py already documents.

Seen on apache/airflow#76510, where the pending checks were Workflow approval, Fork CI gate and two others. Approving through triage and waiting for CI cleared the gate.

Type of change

  • Skill change (.claude/skills/<name>/) — eval fixtures updated below
  • Python package (tools/*/ with pyproject.toml)

Test plan

  • prek run --files <changed files> passes; it updated the plugin copy of disposition.py
  • uv run pytest tests/code_review passes in tools/pr-management
  • The new test_ci_that_never_ran_names_the_workflow_action case fails without the change
  • No eval fixture added: the decision is unchanged and is covered by the unit test

RFC-AI-0004 compliance

  • HITL — the gate stays closed; this only adds guidance, and releasing runs stays a confirmed triage action

Linked issues

Refs #1951.

Notes for reviewers

The gate and the release order are unchanged on purpose. release-runs requires an approval because releasing a run executes the head's code in CI, and this gate exists because auto-merge would not wait for those checks. Whether held runs should get their own path through disposition is a larger question; this only removes the dead end.

🤖 Generated with Claude Code

…e CI gate

When a pending check that is not required kept the CI gate, disposition
set no ci_action. The documented release after approval cannot help
there, since release-runs needs the approval this gate withholds. Point
at waiting or approving the held runs through pr-management-triage, and
give approve-workflow the re-run fallback for runs that answer 403.

Generated-by: Claude Opus 5
@potiuk potiuk added family:pr-management pr-management-* skills capability:fix Implement code change to resolve an issue labels Nov 9, 2026
@github-actions github-actions Bot added family:tools tools/* capability:triage Sweep + classify + propose disposition capability:review Deep per-item code review or contributor mentoring substrate:analytics Tool substrate: read-only metrics / dashboards / renderers labels Nov 9, 2026
@potiuk
potiuk merged commit 26468d2 into apache:main Nov 9, 2026
11 checks passed
@potiuk
potiuk deleted the fix/code-review-held-runs-gate branch November 9, 2026 03:02
potiuk added a commit that referenced this pull request Nov 10, 2026
Brings the specs up to main bfc99bb (37 commits since 1e5c4f9), ahead
of the next dev-version bump:

- security-issue-lifecycle: the import renders the report as defanged
  markdown under a data note, with `description_format: inert` as the
  fenced alternative (#2048).
- adapters: oauth-draft threading by explicit In-Reply-To / References
  (#2051); the typed-decision Jev request shape (#2023).
- adoption-and-setup, marketplace-distribution, codex-runtime: the setup
  sub-action is `update`, and every skill offers the upgrade until it has
  run (#2041); the most specific `sandbox.enabled` wins (#2011); the
  family MCP allows cover single-item reads only (#2020).
- agent-isolation-sandbox: bare `gh auth status` only (#2019); draft
  creation and whole-mailbox search stay prompted (#2020).
- pr-management-family: the CI gate's way out for a non-required check
  (#2029); the adversarial export keeps export-ignore paths (#2030);
  install.md per family (#2031); merge-candidates / thread-mentor names
  (#2025).
- contributor-growth: the candidate-screen committer / PMC headline
  (#2024).
- issue-management-family, repo-health-family: install.md (#2031).
- project-agnosticism: the merge-candidates example path and a re-counted
  example-name gap (#2025).

Generated-by: Claude Opus 5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

capability:fix Implement code change to resolve an issue capability:review Deep per-item code review or contributor mentoring capability:triage Sweep + classify + propose disposition family:pr-management pr-management-* skills family:tools tools/* substrate:analytics Tool substrate: read-only metrics / dashboards / renderers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant