Repository navigation
JSPWIKI-1370 Fix the line endings of the working tree with a .gitattributes file - #635
Open
arturobernalg wants to merge 1 commit into
Open
arturobernalg wants to merge 1 commit into
arturobernalg wants to merge 1 commit into
Conversation
A checkout on Windows with core.autocrlf=true gave CRLF in the working tree, and a source release built from it had CRLF in the text files, including the shell scripts. The files now have LF in every system, and the Windows scripts CRLF.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A checkout on Windows with
core.autocrlf=truegives CRLF in the working tree, and a source release built from it has CRLF in the text files, including the shell scripts: in 3.0.1 RC1 and RC2, 1869 of 1900 text files, andwoas.shof the portable has a CR after the shebang. The files now have LF on every system, and the Windows scripts CRLF.Run on this change: in a clone of master with
core.autocrlf=true, 1597 text files had CRLF andwoas.shhad 45; with this changewoas.shhas none,woas.batkeeps CRLF, andgit statusis clean, in that clone and in one withcore.autocrlf=input.mvn clean packagefrom each of the two clones passes, and thewoas.shinside the portable zip has 45 CRLF when built from the clone without the file and 0 with it.@spyhunter99