Repository navigation
[master-2.x] List only the pages that the viewer may view in the PageViewPlugin list - #632
Merged
Merged
Conversation
The list of the page counters now leaves out the pages that the viewer may not view, as the other plugins that list pages do.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The same change as #631, for master-2.x. The list of the page counters of PageViewPlugin now leaves out the pages that the viewer may not view, with the same check that the other plugins that list pages use. A new test in PageViewPluginTest.
master-2.x does not compile until #630 is merged, so the build of this pull request fails until then. On top of #630, PageViewPluginTest passes and, on a running Tomcat 9, the list does not show the page to a viewer that may not view it.