Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,13 @@
public class PipePluginClassLoader extends URLClassLoader {

private static final String[] PARENT_FIRST_CLASS_PREFIXES = {
"java.", "javax.", "jdk.", "sun.", "org.slf4j.", "org.apache.iotdb.pipe.api."
"java.",
"javax.",
"jdk.",
"sun.",
"org.slf4j.",
"org.apache.iotdb.pipe.api.",
"org.apache.tsfile."
};

private final String libRoot;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,41 @@

public class PipePluginClassLoaderTest {

@Test
public void testTsFileClassesShouldBeLoadedFromParent() throws Exception {
final Path tempDir = Files.createTempDirectory("pipe-plugin-tsfile-classloader-test");
try {
final Path childSources = Files.createDirectory(tempDir.resolve("child-sources"));
final Path childClasses = Files.createDirectory(tempDir.resolve("child-classes"));
final String tabletClassName = "org.apache.tsfile.write.record.Tablet";
final String childTabletSource =
"package org.apache.tsfile.write.record;"
+ "public class Tablet {"
+ " public String source() {"
+ " return \"child\";"
+ " }"
+ "}";
final Map<String, String> childSourceMap = new LinkedHashMap<>();
childSourceMap.put(tabletClassName, childTabletSource);
compile(childSources, childClasses, childSourceMap);

final Path childJar = tempDir.resolve("child.jar");
createJar(
childJar, childClasses, Arrays.asList("org/apache/tsfile/write/record/Tablet.class"));

final ClassLoader parentClassLoader = PipePluginClassLoaderTest.class.getClassLoader();
final Class<?> parentTabletClass = Class.forName(tabletClassName, true, parentClassLoader);
try (final PipePluginClassLoader pluginClassLoader =
new PipePluginClassLoader(childJar.toString(), parentClassLoader)) {
final Class<?> pluginTabletClass = Class.forName(tabletClassName, true, pluginClassLoader);
Assert.assertSame(parentTabletClass, pluginTabletClass);
Assert.assertNotSame(pluginClassLoader, pluginTabletClass.getClassLoader());
}
} finally {
deleteRecursively(tempDir);
}
}

@Test
public void testPluginClassesShouldOverrideParentClasses() throws Exception {
final Path tempDir = Files.createTempDirectory("pipe-plugin-classloader-test");
Expand Down
Loading