Azure: Merge ContextAccessor service registrations in shaded bundle - #17841
Open
Denverper wants to merge 1 commit into
Open
Azure: Merge ContextAccessor service registrations in shaded bundle#17841Denverper wants to merge 1 commit into
Denverper wants to merge 1 commit into
Conversation
Denverper
changed the title
Denverper
commented
Aug 26, 2026
| shadowJar { | ||
| archiveClassifier.set(null) | ||
| zip64 true | ||
| mergeServiceFiles() |
Author
There was a problem hiding this comment.
Denverper
marked this pull request as ready for review
August 26, 2026 23:41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Azure bundle shades Reactor Core and Reactor Netty, which both contribute implementations for
META-INF/services/io.micrometer.context.ContextAccessorBecause duplicate service descriptors are not merged by default, the resulting bundle preserves the Reactor Netty registration but drops
reactor.util.context.ReactorContextAccessor. The implementation class (ReactorContextAccessor) remains in the jar, micrometer cannot discover it through ServiceLoader, meaning we get "No ContextAccessor for contextType" failures at runtime during any azure operations that use ReactorContext when micrometer context propagation is active.The two entries for the same service descriptor that are overwriting eachother:
This PR should merge the ContextAccessor service descriptor to contain both of these implementation so service loader can find both on load and ReactorContext can successfully be read.
A backport to the Iceberg 1.10.x release channel is also requested because affected downstream releases are based on Iceberg 1.10.0.