[FLINK-40556][table] Support UUID value literals backed by byte[] values - #29153
Open
raminqaf wants to merge 1 commit into
Open
[FLINK-40556][table] Support UUID value literals backed by byte[] values#29153raminqaf wants to merge 1 commit into
raminqaf wants to merge 1 commit into
Conversation
UuidType allows both UUID and byte[] as conversion classes, so a ValueLiteralExpression can legally hold a UUID literal as a byte[] value. ValueLiteralExpression#getValueAs(UUID.class) did not handle that case and returned empty, so asSerializableString and ExpressionConverter threw NoSuchElementException or IllegalStateException instead of producing a literal. Add a byte[] to UUID conversion arm to getValueAs, matching the existing coercion pattern for LocalDate, Instant, and other multi-representation types. This single fix covers both call sites since they both go through getValueAs.
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
UuidTypeallows bothUUIDandbyte[]as conversion classes, so aValueLiteralExpressioncan legally hold a UUID literal internally as abyte[].ValueLiteralExpression#getValueAs(UUID.class)didn't handle that case and returned empty, so bothasSerializableStringandExpressionConverterthrewNoSuchElementException/IllegalStateExceptioninstead of producing a literal.Brief change log
byte[]toUUIDconversion arm inValueLiteralExpression#getValueAs, matching the existing coercion pattern forLocalDate,Instant, and other multi-representation types.asSerializableStringandExpressionConverter#visit) with a single change, since both go throughgetValueAs.Verifying this change
This change added tests and can be verified as follows:
ExpressionTest#testUuidValueLiteralExtractionand#testUuidAsSerializableStringare parameterized over a directUUIDliteral and abyte[]-bridged literal.ExpressionConverterTest#testUuidLiteraland#testUuidLiteralFromBytescover the same two cases through the planner's RexNode conversion path.byte[]-backed cases reproduce the original exception before the fix and pass after it.Does this pull request potentially affect one of the following parts:
@Public(Evolving): noDocumentation
Was generative AI tooling used to co-author this PR?
Generated-by: Claude Code (Sonnet 5)