[FLINK-40576][fs] Exclude transitive alluxio dependency from flink-s3-fs-presto - #29145
Open
spuru9 wants to merge 1 commit into
Open
[FLINK-40576][fs] Exclude transitive alluxio dependency from flink-s3-fs-presto#29145spuru9 wants to merge 1 commit into
spuru9 wants to merge 1 commit into
Conversation
…-fs-presto flink-s3-fs-presto pulls in org.alluxio:alluxio-shaded-client transitively via presto-hive. It is only used by Presto's caching filesystem, which the S3 file system does not use. The shaded client is an outdated uber-jar that unnecessarily bloats the bundled plugin, so exclude it and drop it from the bundled NOTICE. Generated-by: Claude Code (claude-opus-4-8)
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
flink-s3-fs-prestotransitively bundlesorg.alluxio:alluxio-shaded-client, pulled in viapresto-hive. It is only used by Presto's caching filesystem, which the Presto S3 file system does not use. The shaded client is an outdated uber-jar that unnecessarily bloats the plugin, so this excludes it from the bundle.Brief change log
org.alluxio:alluxio-shaded-clientfrom thepresto-hivedependency inflink-s3-fs-presto.META-INF/NOTICE.Verifying this change
This change is already covered by existing tests: the
presto_seaweedfs_readend-to-end test (registered inrun-nightly-tests.sh) exercises the Presto S3 file system read path against a local S3-compatible store.Locally verified that
mvn clean install -pl flink-filesystems/flink-s3-fs-presto -amsucceeds (soNoticeFileCheckerpasses), and that the resulting shaded jar contains noalluxioclasses whilePrestoS3FileSystemand the rest of the S3 code path remain intact.Does this pull request potentially affect one of the following parts:
@Public(Evolving): noDocumentation
Was generative AI tooling used to co-author this PR?
Generated-by: Claude Code (claude-opus-4-8)