[FLINK-40600][runtime-web] Add missing web dashboard specs and tighten thin ones - #29135
Open
spuru9 wants to merge 1 commit into
Open
[FLINK-40600][runtime-web] Add missing web dashboard specs and tighten thin ones#29135spuru9 wants to merge 1 commit into
spuru9 wants to merge 1 commit into
Conversation
Collaborator
spuru9
marked this pull request as draft
September 8, 2026 18:44
spuru9
force-pushed
the
FLINK-40600
branch
3 times, most recently
from
September 8, 2026 19:04
efdc60b to
8229b6b
Compare
…n thin ones FLINK-40117 added Vitest specs for most web dashboard views, but pages/application/overview and pages/application/exceptions still had none, and several existing specs only checked that mocked data was loaded rather than what the component derived from it. Adds the two missing specs, and tightens the timeline, job overview, and cluster overview specs to assert their computed values, expands TaskManagerService coverage beyond loadManagers/loadManager, and replaces the HumanizeDatePipe format-'B' test's reliance on an Angular-internal throw with one driven by an unregistered locale. Generated-by: Claude Code (claude-sonnet-5)
spuru9
marked this pull request as ready for review
September 8, 2026 19:10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
FLINK-40117 added Vitest specs for most of the web dashboard views, but
pages/application/overviewandpages/application/exceptionsstill had none. Some of the added specs also only checked that the mocked data was loaded, not what the component derived from it: the timeline spec didn't assert the computed vertex and subtask ranges, the job overview spec never fed a plan intongOnInit, the cluster overview spec didn't assert the derived statistics, andTaskManagerServiceonly had tests forloadManagersandloadManager. TheHumanizeDatePipetest for format'B'relied on Angular throwing for missing locale data, which an Angular upgrade could change.This adds the two missing specs and tightens the existing ones so they fail when the derived values change.
Brief change log
application-overview.component.spec.tsandapplication-exceptions.component.spec.ts.job-timeline.component.spec.tsto assert the computed vertex ranges (including the duration-derived end-time branch and filtering of not-yet-started vertices) and the per-subtask timeline ranges, instead of just checking counts/names.job-overview.component.spec.tswith a new spec that feeds an actual plan intongOnInitand asserts the derivedpendingNodes/pendingLinksand the resultingdagreComponent.flushcall.overview.component.spec.ts(cluster overview) to assert the exact derived cluster-statistics object instead of just checking for static label text.task-manager.service.spec.tsfrom covering onlyloadManagers/loadManagerto covering all public methods.humanize-date.pipe.spec.tstest that relied on Angular throwing for format'B'with one driven by an unregistered locale, which is a stable part of Angular's i18n contract rather than a version-dependent implementation detail.Verifying this change
This change added tests and can be verified as follows:
npx ng test --watch=falseinflink-runtime-web/web-dashboard: 35 spec files / 158 tests pass (up from the prior baseline of 33 files / 139 tests).npm run lintandnpx prettier --checkare clean on all changed/added files.Does this pull request potentially affect one of the following parts:
@Public(Evolving): noDocumentation
Was generative AI tooling used to co-author this PR?
Generated-by: Claude Code (claude-sonnet-5)