refactor: split ClassUtils into metadata resolvers - #1099
Open
nkuprins wants to merge 16 commits into
Open
Conversation
nkuprins
marked this pull request as ready for review
September 13, 2026 19:08
Contributor
Author
|
@bengbengbalabalabeng PTAL, when it's convenient for you 🙏🏻 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closed: #989
Purpose of the pull request
As title
What's changed?
declaredFieldsand its helpers) into a package-privateSheetHeadFieldResolver.declaredExcelContentPropertyand its helpers) into a package-privateSheetContentPropertyResolver.MetadataCacheStrategyperCacheLocationEnumconstant (InMemoryCache,ThreadLocalCache,NoOpCache), each owning its own storage.MetadataCachescomposes the three for one kind of metadata and picks the tier from theConfigurationHolder, soCacheLocationEnumis now referenced in one class instead of three switches.InMemoryCacheandThreadLocalCachealso accept a map or map factory, to allow map types other than the defaults later.ClassUtilskeepsgetAllInterfaces, both key classes, and every public entry point, delegating to the resolvers.FIELD_CACHE,CLASS_CONTENT_CACHEandCONTENT_CACHEin favour ofgetFieldCache()/getClassContentCache()/getContentCache()(unmodifiable, live views; the cached values are shared and must not be modified) and a newremoveInMemoryCache(). The fields still alias the same live, mutable maps, so downstream reads and writes behave exactly as today - only a deprecation warning is added.CacheDataTestno longer reads a privateThreadLocalfield ofClassUtilsand checks that the thread-local cache is cleared after a read throughClassUtilsitself;ClassUtilsTestcovers the three views; newMetadataCacheStrategyTestchecks thatThreadLocalCache.clear()detaches the map from the thread.Checklist