docs: correct global converter write examples - #1091
Open
skytin1004 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of the pull request
The global XLSX/XLS write examples register a converter with a
STRINGkey, but ordinary Excel writes look it up with anullExcel type key. As a result, the custom transformation is skipped. This PR corrects the examples to match that lookup.Related: #889
What's changed?
nullExcel type key for global XLSX/XLS writing in the English and Chinese examples; retainSTRINGfor CSV writing and reading string cells.WriteCellDatadetermines the output cell type.Validation: both XLSX/XLS regression cases fail with the original registration and pass with the corrected key. All 9
CustomConverterTestcases pass on JDK 11, and the fork PR's Java and documentation CI checks pass.Checklist
The Chinese documentation updates were translated with AI. A review of the Chinese wording would be appreciated.