Repository navigation
refactor(hll): simplify coupon serialization and documentation - #291
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HLL List and Set serialization always produces compact images, but both writers retained a hard-coded
compact = trueand unreachable output branches. Remove those branches and use the existing coupon iterators, preserving the declared List count, coupon order, and serialized bytes.Focus HLL public documentation on caller-visible contracts, including hashing compatibility and union precision. Keep independently runnable examples on public methods so callers can use each entry point without reading the module overview. Remove internal mode descriptions and comments that restate the code, retain encoding and estimator invariants, correct stale preamble and table-range descriptions, and link non-obvious formulas and lookup tables to their upstream sources.
Validation:
cargo x check,cargo x test(753 tests, including 142 doctests), andcargo x lintpassed, including rustdoc with warnings denied.lg_k4–21, representation transitions, sparse updatable images, declared List count boundaries, and continued updates after deserialization.