Skip to content

test: cover ArrayStaticFilter and dictionary flattening IN list - #25001

Merged
jayzhan211 merged 1 commit into
apache:mainfrom
peterxcli:test-generic-array-static-filter
Sep 7, 2026
Merged

test: cover ArrayStaticFilter and dictionary flattening IN list#25001
jayzhan211 merged 1 commit into
apache:mainfrom
peterxcli:test-generic-array-static-filter

Conversation

@peterxcli

@peterxcli peterxcli commented Sep 6, 2026

Copy link
Copy Markdown
Member

Which issue does this PR close?

Rationale for this change

The remaining specialized IN-list paths need SQL-level coverage to verify dispatch and end-to-end behavior.

What changes are included in this PR?

Adds SQL logic tests for:

  • generic ArrayStaticFilter values using lists
  • dictionary literal flattening

The cases cover matches, non-matches, nulls, and NOT IN behavior where applicable.

What is the testing strategy for this PR?

slt

Are there any user-facing changes?

No.

@github-actions github-actions Bot added the sqllogictest SQL Logic Tests (.slt) label Sep 6, 2026
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.67%. Comparing base (262936e) to head (c973ef8).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #25001      +/-   ##
==========================================
- Coverage   81.67%   81.67%   -0.01%     
==========================================
  Files        1126     1126              
  Lines      414842   414842              
  Branches   414842   414842              
==========================================
- Hits       338841   338833       -8     
- Misses      56070    56076       +6     
- Partials    19931    19933       +2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@peterxcli peterxcli changed the title test: cover remaining IN list paths test: cover ArrayStaticFilter and dictionary flattening IN list paths Sep 7, 2026
@peterxcli peterxcli changed the title test: cover ArrayStaticFilter and dictionary flattening IN list paths test: cover ArrayStaticFilter and dictionary flattening IN list Sep 7, 2026

@jayzhan211 jayzhan211 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @peterxcli

@jayzhan211
jayzhan211 added this pull request to the merge queue Sep 7, 2026
Merged via the queue into apache:main with commit 38de903 Sep 7, 2026
41 of 42 checks passed
@peterxcli
peterxcli deleted the test-generic-array-static-filter branch September 7, 2026 16:02
@peterxcli

Copy link
Copy Markdown
Member Author

@jayzhan211 thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

sqllogictest SQL Logic Tests (.slt)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SQL / slt coverage for IN lists

3 participants