fix: reject NULL partition keys during partitioned writes - #24951
Draft
bvolpato wants to merge 1 commit into
Draft
fix: reject NULL partition keys during partitioned writes#24951bvolpato wants to merge 1 commit into
bvolpato wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Related to #18083. Full support for NULL partition values remains covered by that issue.
Rationale for this change
Partitioned writes read partition values without checking their validity. A NULL integer partition key can be written under
p=0, so reading the output turns NULL into zero and silently changes the data.For example:
Both rows can end up in the zero partition. This PR rejects the write with
NULL values are not supported for partition column 'p'.What changes are included in this PR?
copy.sltregression covering rejection and a filtered successful write.What is the testing strategy for this PR?
35f58f53cde2f634c21f6370e385cf1d7e9bc55cand pass with the fix.cargo test --locked -p datafusion-datasource --lib: 180 passed.cargo fmt --all -- --checkandgit diff --checkpassed.copy.slt.Are there any user-facing changes?
Partitioned writes containing NULL partition keys now return an execution error. Callers can filter or replace these values before writing. Validation happens per batch, so files written by earlier batches can remain after an error.