Update SQLite expression display expectations - #22
Conversation
|
@alamb, could you please take a look at this companion expectation update when convenient? It matches the 30 SQLite error-message failures from apache/datafusion#23356. With this commit applied, the CI-equivalent SQLite suite passes all 1,098 files; the SQL queries and result expectations are unchanged. Once this merges, I’ll update the DataFusion submodule pin to the resulting main commit. |
|
Hi @goutamadwant -- I will try and review this when I have time, but at the moment I am pretty swamped with other things that I need to review first |
haochunchang
left a comment
There was a problem hiding this comment.
Hi @goutamadwant, @alamb — new to DataFusion, saw this PR was waiting on review bandwidth and wanted to help by independently reproducing the fix locally.
Environment: rustc 1.97.0 (2d8144b78 2026-07-07).
-
Diffed 13bbae3 → 20e8aac line by line and confirmed every changed line matches ^[+-]query error — no SQL query text or expected result rows were altered, only error-message regex expectations.
-
Ran the exact suite command from this PR's description, on apache/datafusion#23356's branch, against both submodule commits: 13bbae3 produced 25 failures (all sqlite slt_good_* files), 20e8aac produced 0 failures
Not in a position to approve, just hoping this saves some review time. Happy to run anything else that'd help.
Rationale
Apache DataFusion PR apache/datafusion#23356 adds precedence-preserving parentheses to nested binary and unary expression display names. The SQLite compatibility tests still expect the previous duplicate-projection error messages.
Changes
Update 30 affected error-message expectations across 25 SQLite test files. The SQL queries and expected query results are unchanged.
Testing
Pointed DataFusion's
datafusion-testingsubmodule at this commit and ran:cargo test --features backtrace,parquet_encryption --profile ci-optimized --test sqllogictests -- --include-sqliteAll 1,098 files completed successfully.