Add build/write-prefetch unparse path with coroutine-driven write dispatch - #1732
Open
olabusayoT wants to merge 3 commits into
Open
olabusayoT wants to merge 3 commits into
olabusayoT wants to merge 3 commits into
Conversation
…patch A build pass now runs ahead of a write pass over the same infoset tree, resolving forward references (OVCs) directly against the tree instead of via Suspensions where possible (useBuildWritePrefetch, off by default). Build and write hand off through a two-thread coroutine (BuildCoroutine/WriteCoroutine); write's traversal blocks via UnparseSharedContext.awaitChild wherever build hasn't caught up, and a build-side failure aborts write via a dedicated signal rather than hanging. Suspension.canResolveWithoutWriting is a static heuristic for which OVC expressions can resolve without a real write, used to skip doomed build-side attempts and to fall back to single-pass entirely when none qualify. dfdl:newVariableInstance reads/writes during build resolve against BuildState's own local scope stack rather than the shared vTable's head, with cloneForSuspension correcting a frozen suspension's VariableMap accordingly. Design Document: https://cwiki.apache.org/confluence/spaces/DAFFODIL/pages/451975094/Build+Write-Prefetch+Unparse+Path DAFFODIL-3065
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A build pass runs ahead of a write pass over the same infoset tree, resolving forward references (OVCs) directly against the tree instead of via Suspensions where possible (useBuildWritePrefetch, off by default). Build and write hand off through a two-thread coroutine (BuildCoroutine/WriteCoroutine); write's traversal blocks via UnparseSharedContext.awaitChild wherever build hasn't caught up, and a build-side failure aborts write via a dedicated signal rather than hanging. Suspension.canResolveWithoutWriting is a static heuristic for which OVC expressions can resolve without a real write, used to skip doomed build-side attempts and to fall back to single-pass entirely when none qualify. dfdl:newVariableInstance reads/writes during build resolve against BuildState's own local scope stack rather than the shared vTable's head, with cloneForSuspension correcting a frozen suspension's VariableMap accordingly.
Design Document: https://cwiki.apache.org/confluence/spaces/DAFFODIL/pages/451975094/Build+Write-Prefetch+Unparse+Path
DAFFODIL-3065